[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Thank you @zequanwu, for providing the minimized reproducer! It really made fixing this much easier! :) I've re-landed the change and added a test specifically for this issue: `lower-global-dtors-existing-dos_handle.ll` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

zequanwu added a comment. Herald added a subscriber: pmatos. Hi, this causes crash on Mac building bot. Here is the reduced repro: `opt -lower-global-dtors /tmp/reduced.ll -o /dev/null ` $ cat /tmp/reduced.ll %struct.mach_header = type { i32, i32, i32, i32, i32, i32, i32 }

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. In D121736#3389251 , @RKSimon wrote: > LGTM - but please hang around after you commit Thanks! Looks like this it worked out. Let me know if there is any other problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22570bac6943: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but please hang around after you commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121736/new/ https://reviews.llvm.org/D121736

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Plan to land tomorrow morning. Test passes on the Debian bot : PASS: LLVM :: Transforms/LowerGlobalDestructors/lower-global-dtors.ll (72299 of 93291) Repository: rG

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. I've added 2 additional calls to `initializeLowerGlobalDtorsLegacyPassPass()`. The one in the constructor of the legacy pass should ensure that the pass is always registered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. It looks like all tests succeed for `x64 debian`: https://buildkite.com/llvm-project/premerge-checks/builds/83802#c5002be5-e01c-46fc-a767-50fe6f854465 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121736/new/

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Hi @Orlando and @RKSimon, would you be able to confirm that this version avoids the previous `opt: Unknown command line argument '-lower-global-dtors'` error? Lit invocation: `env LIT_FILTER='dtor' ninja check-llvm` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln created this revision. yln added reviewers: Orlando, RKSimon. Herald added subscribers: asb, ormris, pengfei, sunfish, hiraditya, jgravelle-google, sbc100, mgorny, dschuff. Herald added a project: All. yln requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,