[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57ee624d7946: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall updated this revision to Diff 418285. sammccall added a comment. Rebase. Also update LLD since it's simple and similar to clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121763/new/ https://reviews.llvm.org/D121763 Files: clang-to

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_M

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_MODE}" CURRENT_TOOLS_DIR "${LLVM_RUNTIME_OUTPUT_INTDIR}") + string(REPLACE "

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 + # Like LLVM_{TOOLS,LIBS}_DIR, but pointing at the build tree. + string(REPLACE "${CMAKE_CFG_INTDIR}" "${LLVM_BUILD_MODE}" CURRENT_TOOLS_DIR "${LLVM_RUNTIME_OUTPUT_INTDIR}") + string(REPLACE "${C

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added a comment. In D121763#3385492 , @hokein wrote: > I think this patch is probably doing too much: 1. move CLANG_TOOLS_DIR to > `configure_site_lit_cfg()` 2. rename. > > Can we split it into two patches? Land the first part, and the second p

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

hokein added a comment. I think this patch is probably doing too much: 1. move CLANG_TOOLS_DIR to `configure_site_lit_cfg()` 2. rename. Can we split it into two patches? Land the first part, and the second part afterwards. Comment at: llvm/cmake/modules/AddLLVM.cmake:1640 +

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added a comment. Trolling for reviewers: @hokein: this is another -10 lines per test suite! @thakis: the GN changes seem trivial (no standalone build) but wonder if you have opinions @mgorny: because I don't truly understand the standalone build, and only hope I'm getting this right

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall updated this revision to Diff 415672. sammccall added a comment. add gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121763/new/ https://reviews.llvm.org/D121763 Files: clang-tools-extra/clangd/test/CMakeLists.txt clang-tools-extra/

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall created this revision. sammccall added reviewers: hokein, thakis, mgorny. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe