[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added a comment. Thanks, Gabor -- that's a really helpful summary! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 ___ cfe-commits mailing list

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + } ymandel wrote: > xazax.hun wrote: > > ymandel wrote:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added a comment. In D121797#3392444 , @xbolva00 wrote: > Why this should be maintained and developed by LLVM/Clang developers and not > by Chromium? That's a good question. I think the short answer, that skirts around the issue, is that this

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xbolva00 added a comment. Why this should be maintained and developed by LLVM/Clang developers and not by Chromium? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36c2dd6d54c: [clang][dataflow] Add modeling of Chromiums CHECK functionality (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + } xazax.hun wrote: > ymandel wrote: > > xazax.hun wrote:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 416494. ymandel marked 6 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 416479. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/ChromiumCheckModel.h:15 + +#include "clang/AST/ASTContext.h" +#include "clang/AST/DeclCXX.h" This is unnecessary.

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + } ymandel wrote: > xazax.hun wrote: > > I wonder

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + }

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 415936. ymandel marked an inline comment as done. ymandel added a comment. removed lattice dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:206 + +EXPECT_TRUE(Env.flowConditionImplies(*FooVal)); + }; gribozavr2 wrote: > Sorry, could you

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel updated this revision to Diff 415821. ymandel added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 Files:

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp:16-17 +namespace dataflow { +/// Determines whether `D` is one of the methods used to implement Chromium's +/// `CHECK` macros. +bool

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Chromium's implementation of assertions (`CHECK`,