[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Thanks for the revert @gulfem. I was hoping I'll be able to quickly forward-fix the issue, but turns out there's more to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

gulfem added a comment. In D121812#3405060 , @jansvoboda11 wrote: > Sorry for the breakage and thanks for reporting this! This is a real bug > uncovered by your build using `/opt`. I have a fix here: D122385 > .

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Sorry for the breakage and thanks for reporting this! This is a real bug uncovered by your build using `/opt`. I have a fix here: D122385 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

gulfem added a comment. Newly added tests `ClangScanDeps/cl-output.c` and `ClangScanDeps/cl-xclang.c` started failing in our Mac toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b881168677577537/overview Here's the link to the log:

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30cb49b44e4e: [clang][deps] NFC: De-duplicate clang-cl tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3 + +// REQUIRES: shell + saudi wrote: > I was wondering whether it could be a concern that this test will be skipped > on Windows systems, where `clang-cl` specific

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi added a comment. Sorry, I flagged this as "accepted", but I'm not sure I am allowed to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi accepted this revision. saudi added a comment. This revision is now accepted and ready to land. It is indeed much cleaner this way`, thanks! The tests are not anymore the same for `clang-cl` as for `clang`, but I agree what needs testing is the clang-cl specific behaviors, not having the

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 updated this revision to Diff 415857. jansvoboda11 added a comment. Add `-NEXT` to a check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 Files:

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 updated this revision to Diff 415856. jansvoboda11 added a comment. Remove backslashes from make output checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 Files:

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D92191 , a bunch