[PATCH] D121907: [clang-format] Use an enum for context types. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sstwcw marked an inline comment as done. Closed by commit rG8c31b68f4876: [clang-format] Use an enum for context types. NFC (authored by sstwcw). Repository: rG LLVM

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

curdeius accepted this revision. curdeius added a comment. I really like this change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits ma

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

owenpan accepted this revision. owenpan added a comment. LGTM. Any comments, @curdeius? Comment at: clang/lib/Format/TokenAnnotator.cpp:116 // template parameter, not an argument. -Contexts.back().InTemplateArgument = -Left->Previous && Left->Previous->isNot(to

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay added a comment. Please wait for the other reviewers if you have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits m

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think fundamentally this look ok? @curdeius and @owenpan I feel I want to bow to your better judgement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw updated this revision to Diff 416458. sstwcw added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 Files: clang/lib/Format/TokenAnnotator.cpp Index: clang/lib/Format/T

[PATCH] D121907: [clang-format] Use an enum for context types.

HazardyKnusperkeks added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the wrong design > and its bett

[PATCH] D121907: [clang-format] Use an enum for context types.

MyDeveloperDay added a comment. So out of interest, what is the reason? my assumption is that you wanted to add more for Verilog and you felt adding the extra bools was the wrong design and its better an an enum bool InCpp11AttributeSpecifier = false; bool InCSharpAttributeSpecifier = false

[PATCH] D121907: [clang-format] Use an enum for context types.

owenpan added subscribers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. owenpan added a comment. If this patch is an NFC, please add `[NFC]` to the title. Please add @MyDeveloperDay @curdeius @HazardyKnusperkeks to Reviewers. Comment at: clang/lib/Format/TokenAnnota

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have all those fields in AnnotatingP