[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rGedbb99a7edc6: Ensure -extract-api handles multiple headers correctly (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM. Thanks Daniel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416942. dang added a comment. Rebase on top of main to bring latest fixes to ExtractAPIAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files:

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3391001 , @zixuw wrote: > In D121936#3390920 , @dang wrote: > >> In D121936#3389991 , @ributzka >> wrote: >> >>> Nice! Thank you for

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

zixuw added a comment. In D121936#3390920 , @dang wrote: > In D121936#3389991 , @ributzka > wrote: > >> Nice! Thank you for adding support for multiple headers. Is this a step >> towards the json input file

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416359. dang added a comment. Add test to check that command line with different header kinds gets diagnosed appropriately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3389991 , @ributzka wrote: > Nice! Thank you for adding support for multiple headers. Is this a step > towards the json input file list? My understanding was that for this iteration at least we were going with just

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added inline comments. Comment at: clang/include/clang/Driver/Phases.h:17 /// compilation process which interact with user options. - enum ID { -Preprocess, ributzka wrote: > Is this an unrelated formatting change? Fixed it in the latest diff. I had

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. If people thing it would be preferable to add a new phase and change phase scheduling a little I am happy to do that too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

ributzka added a comment. Nice! Thank you for adding support for multiple headers. Is this a step towards the json input file list? Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:467 +def err_drv_extract_api_wrong_kind : Error< + "header file '%0' input

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

ributzka added inline comments. Comment at: clang/include/clang/Driver/Phases.h:17 /// compilation process which interact with user options. - enum ID { -Preprocess, Is this an unrelated formatting change? Comment at:

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416261. dang added a comment. Get rid of spurious clang-format changes due to reverted modifications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files:

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang created this revision. dang added reviewers: ributzka, zixuw, QuietMisdreavus, arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang -extract-api should accept multiple headers and forward