[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe471ba3d0122: [Object] Add binary format for bundling offloading metadata (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 422544. jhuber6 added a comment. Maxing suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: llvm/include/llvm/Object/OffloadBinary.h

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Couple of nits above but basically I'm convinced. The gnarly part of binary formats is string tables and I'm delighted that part of MC was readily reusable. Wrapping the

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. Ping, I'd like to finalize the new driver in time for the GPU newsletter and the LLVM Performance Workshop at CGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3416694 , @saiislam wrote: > Hey @jhuber6 , as discussed in multi-company meeting, I think that we will > need at least an arch field somewhere in this. We would like to create > multi-arch binaries so that runtime

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

saiislam added a comment. Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own. You may even consider using TargetID Format

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3413960 , @JonChesterfield wrote: > Added some reviewers. I'd much prefer this used an existing binary format, > DIY is prone to errors and maintenance hassles down the road. Don't care as > much about which format

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

JonChesterfield added reviewers: grokos, ABataev, ronlieb, tianshilei1992. JonChesterfield added a comment. Added some reviewers. I'd much prefer this used an existing binary format, DIY is prone to errors and maintenance hassles down the road. Don't care as much about which format as about it

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 418255. jhuber6 added a comment. Changing test, `uniform_int_distribution` doesn't support `char` or `uint8_t` according to the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/