[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d165ad7d9b3: In fast-math mode, when unsafe math optimizations are enabled, the (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 ___ cfe-commits

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 420168. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 420035. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 419763. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaAttr.cpp

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 419746. Herald added a subscriber: pengfei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418936. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:52-53 +def err_incompatible_fp_eval_method_options : Error< +"option 'ffp-eval-method' cannot be used with" +" %select{option 'fapprox-func'|option 'mreassociate'|option

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418597. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418210. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"results of

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:492 +Diag(Loc, + diag::warn_eval_method_setting_via_pragma_in_value_unsafe_context); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); Not sure if I should repeat

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417356. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:127-129 +def warn_eval_method_setting_is_meaningless_in_value_unsafe_context :

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417279. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Sema/Sema.cpp

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1065 + if (Tok.isNot(tok::annot_pragma_fp) && + getLangOpts().getFPEvalMethod() != LangOptions::FEM_UnsetOnCommandLine && zahiraam wrote: > aaron.ballman wrote: > > This looks

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1065 + if (Tok.isNot(tok::annot_pragma_fp) && + getLangOpts().getFPEvalMethod() != LangOptions::FEM_UnsetOnCommandLine && aaron.ballman wrote: > This looks like it's going to

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:127 +def warn_eval_method_setting_is_meaningless_in_value_unsafe_context: Warning< + "setting the eval method via the `ffp-eval-method` option or the `pragma clang fp

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, rjmccall, thakis, fhahn. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting the eval method via the `ffp-eval-method` option or via the `#pragma