mgehre-amd added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:315
#define BENIGN_ENUM_LANGOPT(Name, Type, Bits, Default, Description)
-#define BENIGN_VALUE_LANGOPT(Name, Type, Bits, Default, Description)
+#define BENIGN_VALUE_LANGOPT(Name, Bits, Default,
mgehre-amd updated this revision to Diff 418861.
mgehre-amd added a comment.
Herald added a subscriber: dexonsmith.
- Remove diagnostics for float-to-bitint
- Remove lexer changes (will be another PR)
- Add -fexperimental-max-bitint-width=N
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
mgehre-amd wrote:
>
mgehre-amd marked 2 inline comments as done.
mgehre-amd added inline comments.
Herald added a subscriber: MaskRay.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
mgehre-amd wrote:
>
mgehre-amd marked 3 inline comments as done.
mgehre-amd added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
erichkeane added inline comments.
Comment at: clang/lib/Lex/LiteralSupport.cpp:1232
+ if (llvm::isPowerOf2_32(radix)) {
+unsigned BitsPerDigit = llvm::Log2(radix);
mgehre-amd wrote:
> erichkeane wrote:
> > Can you explain what is going on here? This
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
mgehre-amd wrote:
>
mgehre-amd marked an inline comment as done.
mgehre-amd added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
erichkeane added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422
+def err_int_to_float_bit_int_max_size : Error<
+ "cannot convert '_BitInt' operands of more than %0 bits to floating point">;
Can you explain the issue here?
mgehre-amd created this revision.
mgehre-amd added reviewers: aaron.ballman, erichkeane.
Herald added subscribers: luke957, s.egerton, mstorsjo, simoncook,
fedor.sergeev, dschuff.
Herald added a project: All.
mgehre-amd requested review of this revision.
Herald added subscribers: pcwang-thead,
11 matches
Mail list logo