[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 495925. abidmalikwaterloo added a comment. Rebase the patch to origin/main with all updates. Made changes to make it buildable using the new changes. (WIP). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 483422. abidmalikwaterloo marked 8 inline comments as done and an inline comment as not done. abidmalikwaterloo added a comment. Clean the formatting comments. The patch is out of attention for a while. Still need to work on the context selector

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:19 #include "clang/Basic/LLVM.h" +#include "clang/AST/StmtOpenMP.h" // #include "clang/Basic/OpenMPKinds.h" Remove empty comment Comment at:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 461661. abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. Updated the PrintStmt.cpp according to the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. I will work on the patch in parts. I am planning to submit taking care of comments except for comments for SemaOpenMP and code generation. Comment at: clang/lib/AST/OpenMPClause.cpp:1679 +

[PATCH] D122255: Meta directive runtime support

jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1679 + OS << ": "; +} + abidmalikwaterloo wrote: > jdoerfert wrote: > > I'm assuming we already have a printer for trait selectors, no? Doesn't > > `OMPTraitInfo::print` do this

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:3144 +for (const OMPTraitSelector : Set.Selectors) { + if (Selector.Kind == llvm::omp::TraitSelector::user_condition

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10852 +def err_omp_misplaced_default_clause : Error< + "misplaced default clause! Only one default clause is allowed in" +

[PATCH] D122255: Meta directive runtime support

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10852 +def err_omp_misplaced_default_clause : Error< + "misplaced default clause! Only one default clause is allowed in" + "metadirective in the end">; ABataev wrote:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Ping! Comment at: clang/lib/AST/OpenMPClause.cpp:1614-1617 + if (Node->getTI().Sets.size() == 0) { +OS << "default("; +return; + } ABataev wrote: > Is this correct? Just `default(` is expected to be printed? This

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 442661. abidmalikwaterloo marked 14 inline comments as done. abidmalikwaterloo added a comment. Updated and clean the code based on the comments from the reviewer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + abidmalikwaterloo wrote: > ABataev wrote: > > make it private > Any

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8859 +/// \code +/// #pragma omp metadirective when(user={consition(N<100)}:parallel for) +/// \endcode condition? Comment at:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Should I update the patch? I am waiting for quick feedback on the concept of handling conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 423305. abidmalikwaterloo added a comment. Cleaned the code and added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 Files:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. The last update removed all previous updates. Can you point me to the correct way to do it? I did the following : arc patch D122255 "did something/cleaning" git commit -a --amend arc diff Repository: rG LLVM Github

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422512. abidmalikwaterloo added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 Files:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422509. abidmalikwaterloo added a comment. I update it but it created a new patch D123598 . I marked it Abandon. Not sure how to delete it. I am submitting it again after cleaning the codes and adding some basic

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. There should be an update to D122255 . It should not create the new one.D123598 ---> I did the following : arc patch D122255 "did something/cleaning" git

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. would it make sense to submit separate patches for when (OMPC_when) and otherwise (OMPC_otherwise) clauses? The D120573 also has OMPC_when support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D122255: Meta directive runtime support

I quickly went through the D120573. There are many overlapping. On Tue, Mar 22, 2022 at 4:23 PM Johannes Doerfert via Phabricator < revi...@reviews.llvm.org> wrote: > jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. > jdoerfert added a comment. > > This contains a lot of unrelated

[PATCH] D122255: Meta directive runtime support

jdoerfert added a comment. In D122255#3400636 , @abidmalikwaterloo wrote: > Is it okay if I can put comments on the patch? Not sure what you mean but feel free. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Is it okay if I can put comments on the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 ___ cfe-commits mailing list

[PATCH] D122255: Meta directive runtime support

jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. jdoerfert added a comment. This contains a lot of unrelated changes, leftover comments, etc. As you clean up the code, please also include tests. Clang format the patch, go over the new code and make sure you follow the coding style.

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,