[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:400 + /// then the return value is 0 + /// and the note may say "Assuming the character is non-alphabetical". + class

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf68c0a2f58e4: [analyzer] Add path note tags to standard library

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:879 +// knowing in advance which branch is taken. +return (Node->succ_size() > 1) ? Note.str() : ""; + }, NoQ wrote: >

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:872-883 +if (NewState && NewState != State) { + StringRef Note = Case.getNote(); + const NoteTag *Tag = C.getNoteTag( + // Sorry couldn't help myself.

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:400 + /// then the return value is 0 + /// and the note may say "Assuming the character is non-alphabetical". + class SummaryCase { It would

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:872-883 +if (NewState && NewState != State) { + StringRef Note = Case.getNote(); + const NoteTag *Tag = C.getNoteTag( + // Sorry couldn't help

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added a comment. I think interestingness definitely requires more work. In particular, in null dereference from `getenv()`, the note should be unprunable. But we can't control prunability dynamically yet, so it requires a bit more work. So I think this patch is ok to go and I'll hopefully

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ updated this revision to Diff 420701. NoQ added a comment. - Eliminate notes on known paths. - Add some documentation for the new class. - Mostly moved from existing documentation for the entire summary class. - Fix incorrect assessment that Exploded Graph is a tree. It's not even

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ planned changes to this revision. NoQ added a comment. Ok there's actually a huge bug in this patch, namely we can't say "Assuming..." if there's no state split (i.e., when we know from the start which branch is taken so we don't have to assume). I'll fix. In D122285#3401754

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

Szelethus added a comment. LGTM on my end, this is awesome! In D122285#3401754 , @steakhal wrote: >> The notes are prunable, i.e. they won't bring-in entire stack frames worth >> of notes just because they're there, but they will be always visible >>

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

steakhal added a comment. > The notes are prunable, i.e. they won't bring-in entire stack frames worth of > notes just because they're there, but they will be always visible regardless > of whether the value is of interest to the bug report. I think this is > debatable, the arguably better

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:41 // -// The following standard C functions are currently supported: -// This comment has been out of date for years and I don't think it makes sense to

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ created this revision. NoQ added reviewers: t-rasmud, Szelethus, martong, steakhal, ASDenysPetrov, balazske, gamesh411. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. NoQ requested