This revision was automatically updated to reflect the committed changes.
Closed by commit rG0ee06c31aa57: [clang][extract-api] Stop allocating
APIRecords via BumpPtrAllocator (authored by dang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:326
+ /// Note: The main use for this is being able to deduplicate strings.
llvm::BumpPtrAllocator Allocator;
zixuw wrote:
> zixuw wrote:
> > Should we just rename the allocator
dang updated this revision to Diff 417885.
dang marked 2 inline comments as done.
dang added a comment.
Address review feedback: Rename APISet::Allocator to APISet::StringAllocator
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122331/new/
dang added a comment.
I have checked locally against San to make sure this doesn't reintroduce the
memory leak issues we were seeing initially that lead to the addition of
`APIRecordUniquePtr`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
zixuw added a comment.
This is much cleaner now. Thanks Daniel!
Comment at: clang/include/clang/ExtractAPI/API.h:326
+ /// Note: The main use for this is being able to deduplicate strings.
llvm::BumpPtrAllocator Allocator;
Should we just rename the
dang created this revision.
dang added reviewers: zixuw, QuietMisdreavus, ributzka.
Herald added a project: All.
dang requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Using a BumpPtrAllocator introduced memory leaks for APIRecords as they
