[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 420299. abrachet added a comment. Fixing failing tests in Modules/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419170. abrachet marked 2 inline comments as done. abrachet added a comment. reabase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1434 StringRef AdditionalInformation, CompilationDiagnosticReport *Report) { +#ifdef CLANG_CRASH_SAVE_TEMPS + constexpr bool SaveReproTemps = true;

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419165. abrachet marked 2 inline comments as done. abrachet added a comment. - Define `CLANG_CRASH_SAVE_TEMPS` in config.h and not with `add_definitions` - Add `CLANG_CRASH_SAVE_TEMPS` env var to force emitting individual preprocessed sources CHANGES

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

arichardson added inline comments. Comment at: clang/CMakeLists.txt:520 + ON "${CMAKE_BUILD_TYPE} MATCHES Debug" OFF) +if(CLANG_CRASH_SAVE_TEMPS) + add_definitions(-DCLANG_CRASH_SAVE_TEMPS) Could you add this to the config.h header

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419014. abrachet added a comment. Herald added a subscriber: mgorny. - Add new build option `CLANG_CRASH_SAVE_TEMPS` which defaults to Off, or On if `CMAKE_BUILD_TYPE` is Debug. It retains the old behavior alongside the tar file. - Mark tests which use

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3404754 , @arichardson wrote: > In D122335#3404358 , @jrtc27 wrote: > >> As a developer who often deals with crashes locally this is more annoying; >> currently I can

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

arichardson added a comment. In D122335#3404358 , @jrtc27 wrote: > As a developer who often deals with crashes locally this is more annoying; > currently I can just point tools at the shell script and C file in /tmp and > let them go to work reducing,

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

jrtc27 added a comment. As a developer who often deals with crashes locally this is more annoying; currently I can just point tools at the shell script and C file in /tmp and let them go to work reducing, but now I have to also extract the files CHANGES SINCE LAST ACTION

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417756. abrachet added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp clang/test/Driver/crash-diagnostics-dir.c

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. In D122335#3403474 , @aaron.ballman wrote: > Yup, I'm okay with that compiler engineer requirement; I think our existing > requirements on Windows already pull in a useful `tar` program even though it > doesn't seem like we

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417754. abrachet added a comment. Herald added a subscriber: arphaman. Fix test failures outside of Driver/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403459 , @erichkeane wrote: > In D122335#3403453 , @aaron.ballman > wrote: > >> In D122335#3403357 , @erichkeane >> wrote:

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403453 , @aaron.ballman wrote: > In D122335#3403357 , @erichkeane > wrote: > >> In D122335#3403305 , >> @aaron.ballman wrote:

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403357 , @erichkeane wrote: > In D122335#3403305 , @aaron.ballman > wrote: > >> In D122335#3403283 , @abrachet >> wrote: >>

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403305 , @aaron.ballman wrote: > In D122335#3403283 , @abrachet > wrote: > >> In D122335#3403281 , >> @hubert.reinterpretcast

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403283 , @abrachet wrote: > In D122335#3403281 , > @hubert.reinterpretcast wrote: > >> For users on Windows, would this cause extra trouble if they wanted to see >>

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. In D122335#3403281 , @hubert.reinterpretcast wrote: > For users on Windows, would this cause extra trouble if they wanted to see > what was included? Is `tar(1)` not available on Windows? CHANGES SINCE LAST ACTION