[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 added a comment. In D122338#3405948 , @ABataev wrote: > LG Thank you so much Alexey. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988 if (isa(E)) { Pos = ParamPositions[FD]; } else {

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6cdac48ffaf: Eliminate extra set of simd variant function attribute. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417981. jyu2 added a comment. Address Alexey comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11992-11993 ->getCanonicalDecl(); + assert(ParamPositions.find(PVD) != ParamPositions.end()); Pos = ParamPositions[PVD]; }

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11992 ->getCanonicalDecl(); + assert(ParamPositions.find(PVD) != ParamPositions.end()); Pos = ParamPositions[PVD]; Better to use

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417944. jyu2 added a comment. Address Alexey's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988 if (isa(E)) { Pos = ParamPositions[FD]; } else { I would also recommend to replace all `operator []` calls to something that does not modify the

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417746. jyu2 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index:

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 added a comment. In D122338#3403414 , @ABataev wrote: > If ParamPositions grows, it means that the item is not found. Is it correct > behavior if the compiler inserts new item in the ParamPositions map? I see. Thanks! Then it seems

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added a comment. If ParamPositions grows, it means that the item is not found. Is it correct behavior if the compiler inserts new item in the ParamPositions map? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.