[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

sammccall added a comment. Herald added a subscriber: wangpc. In D122529#3422158 , @aaron.ballman wrote: > This looks good? to me. :-) > > Despite this complicating things by a fair amount, I don't have a better > suggestion to offer. LGTM

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ad3c3891e5: Reland [ASTMatchers] Output currently matching node on crash (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

aaron.ballman added a comment. In D122529#3422688 , @njames93 wrote: > In D122529#3422158 , @aaron.ballman > wrote: > >> This looks good? to me. :-) >> >> Despite this complicating things by a fair

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 added a comment. In D122529#3422158 , @aaron.ballman wrote: > This looks good? to me. :-) > > Despite this complicating things by a fair amount, I don't have a better > suggestion to offer. LGTM This was the "nicest" cheapest way I

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks good? to me. :-) Despite this complicating things by a fair amount, I don't have a better suggestion to offer. LGTM Comment at:

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 419690. njames93 added a comment. Use macro to reduce duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 419662. njames93 added a comment. Split PointerUnion to work on 32bit platforms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files:

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e33e45b9430: [ASTMatchers] Output currently matching node on crash (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D122529?vs=418473=419178#toc Repository: rG LLVM Github

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 updated this revision to Diff 418473. njames93 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, LegalizeAdulthood. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend D120185 to