[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham). Repository: rG LLVM Github Monorepo

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://reviews.llvm.org/D122549

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham updated this revision to Diff 418959. bnbarham added a comment. Keep using the redirection hack for the time being Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://reviews.llvm.org/D122549 Files:

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham marked an inline comment as not done. bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. dexonsmith wrote: >

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. bnbarham wrote: > bnbarham wrote: > > dexonsmith wrote: > > > An

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. bnbarham wrote: > dexonsmith wrote: > > An incremental patch you

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham marked 4 inline comments as done. bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. dexonsmith wrote: > An

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham updated this revision to Diff 418721. bnbarham edited the summary of this revision. bnbarham added a comment. Rename `IsVFSMapped` as suggested by Duncan. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. An incremental patch you could try would be: ``` lang=c++ if

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham added a comment. In D122549#3412064 , @dexonsmith wrote: > In D122549#3412021 , @bnbarham > wrote: > >> `clang-apply-replacements/relative-paths.cpp` is failing, I haven't looked >> into it but my

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added a comment. In D122549#3412021 , @bnbarham wrote: > `clang-apply-replacements/relative-paths.cpp` is failing, I haven't looked > into it but my guess would be that it's from the `Status.getName() == > Filename` -> `!Status.IsVFSMapped`

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham added a comment. `clang-apply-replacements/relative-paths.cpp` is failing, I haven't looked into it but my guess would be that it's from the `Status.getName() == Filename` -> `!Status.IsVFSMapped` change. That seems very odd to me. Comment at:

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added a comment. This looks nice! Comment at: clang/lib/Basic/FileManager.cpp:287-289 // name-as-accessed on the \a FileEntryRef. Maybe the returned \a // FileEntryRef::getName() could return the accessed name unmodified, but // make the external name

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham created this revision. bnbarham added reviewers: dexonsmith, keith, JDevlieghere, vsapsai, sammccall. Herald added a subscriber: hiraditya. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,