[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang closed this revision. dang added a comment. a9909d23e9bb8c4649cba1c14d479c28df4ca185 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 ___ cfe-commits mailing list

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any inputs. This generates a /// single header that

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419205. dang added a comment. Update using the correct patch this time around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419197. dang marked 2 inline comments as done. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files:

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

zixuw added a comment. Mostly LGTM after addressing the inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 418907. dang added a comment. Some errors slipped by when splitting this out of the macros patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files:

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the API records a property of the action instead of the ASTVisitor