[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

hjl.tools added a comment. In D122789#3447413 , @pengfei wrote: > In D122789#3446865 , @MaskRay wrote: > >> To kurly (original Gentoo reporter): >> >> printf '#include \n#include \nuint32_t >>

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. GCC supports "-mcrc32", but seems only for built-in functions: https://godbolt.org/z/veeGMoY11 https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html#x86-Options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a subscriber: hjl.tools. pengfei added a comment. In D122789#3446865 , @MaskRay wrote: > To kurly (original Gentoo reporter): > > printf '#include \n#include \nuint32_t > computeHardwareCRC32(uint32_t Crc, uint32_t Data) { return

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

MaskRay added a comment. This is to kurly (original Gentoo reporter) `printf '#include \n#include \nuint32_t computeHardwareCRC32(uint32_t Crc, uint32_t Data) { return _mm_crc32_u32(Crc, Data); }' > a.c` `clang -m32 -march=i686 -msse4.2 -c a.c` seems to compile fine. I have some older GCC and

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3424226 , @MaskRay wrote: > In D122789#3424213 , @pengfei wrote: > >> In D122789#3423846 , @MaskRay >> wrote: >> >>> Is this a

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

MaskRay added a comment. In D122789#3424213 , @pengfei wrote: > In D122789#3423846 , @MaskRay wrote: > >> Is this a problem with D105462 ? Should >> -msse4.2 imply -mcrc32? > >

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. So it's interesting, it shouldn't fail that way https://godbolt.org/z/jcqx5x9j7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3423846 , @MaskRay wrote: > Is this a problem with D105462 ? Should > -msse4.2 imply -mcrc32? -msse4.2 implies -mcrc32: https://godbolt.org/z/xaPccrKx3 Repository: rG LLVM Github

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

MaskRay added a comment. Is this a problem with D105462 ? Should -msse4.2 imply -mcrc32? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd1da784ac64: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Not familiar with this code, but the newest version does resolve the build failure with GCC, so I guess this is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

mgorny updated this revision to Diff 419666. mgorny added a comment. Used `__builtin_ia32_crc32*` along with `-mcrc32` to fix compatibility with GCC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 Files: compiler-rt/cmake/config-ix.cmake

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b53121c323: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny). Herald added a subscriber: Sanitizers. Repository: rG

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___ cfe-commits mailing list

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

mgorny created this revision. mgorny added reviewers: kostyakozko, MaskRay, alekseyshl, tianqing, pengfei. mgorny added a project: Sanitizers. Herald added subscribers: StephenFan, cryptoad, dberris. Herald added a project: All. mgorny requested review of this revision. Update the hardware CRC32