This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tahonermann marked an inline comment as done.
Closed by commit rGbed5ee3f4ba2: [clang] NFC: Enhance comments in CodeGen for
multiversion function support. (authored by
erichkeane accepted this revision.
erichkeane added a comment.
Still LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122955/new/
https://reviews.llvm.org/D122955
___
cfe-commits mailing list
tahonermann updated this revision to Diff 420586.
tahonermann added a comment.
Reworded a comment to address code review commentary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122955/new/
https://reviews.llvm.org/D122955
Files:
erichkeane accepted this revision.
erichkeane added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Basic/Attr.td:2730
+// used for the "default" variant be the largest mangling ID in the
+// variant set. Note that, if
tahonermann created this revision.
tahonermann added reviewers: erichkeane, aaron.ballman.
Herald added a project: All.
tahonermann added inline comments.
tahonermann published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
