[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2023-06-13 Thread James Y Knight via Phabricator via cfe-commits
jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1333 +CalleeDecl->getOverloadedOperator() == OO_Delete) { + CallOrInvoke->addParamAttr(0, llvm::Attribute::AllocatedPointer); +} Perhaps we should add this attribute to

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2023-06-13 Thread Augie Fackler via Phabricator via cfe-commits
durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2023-06-08 Thread Augie Fackler via Phabricator via cfe-commits
durin42 updated this revision to Diff 529613. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGen/pr53127.cpp

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2023-06-07 Thread Augie Fackler via Phabricator via cfe-commits
durin42 updated this revision to Diff 529444. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2022-04-06 Thread Augie Fackler via Phabricator via cfe-commits
durin42 planned changes to this revision. durin42 added a comment. I'll hold off on this one until the other LLVM patches are done, then mail out the clang work as its own logical unit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2022-04-06 Thread Augie Fackler via Phabricator via cfe-commits
durin42 updated this revision to Diff 420915. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cxx1y-sized-deallocation.cpp

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2022-04-06 Thread Augie Fackler via Phabricator via cfe-commits
durin42 edited the summary of this revision. durin42 updated this revision to Diff 420854. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

2022-04-04 Thread Augie Fackler via Phabricator via cfe-commits
durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this change, we're almost ready to drop the entire table out of MemoryBuiltins.cpp and rely solely on attributes to