[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rG236b6a0eb41a: [clang][extract-api] Emit functionSignature in SGF for ObjC methods. (authored by dang).

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123304/new/ https://reviews.llvm.org/D123304 ___

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature",

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", dang wrote: > zixuw wrote: > > I'd prefer

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", zixuw wrote: > I'd prefer not to use

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang updated this revision to Diff 421932. dang added a comment. Address code review feedback. Introduce `has_function_signature` type trait to distinguish records that have a function signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", I'd prefer not to use `dyn_cast` as

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123304 Files: