This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ec501da76fc: [OpenMP] Refactor OMPScheduleType enum.
(authored by Meinersbur).
Changed prior to commit:
https://reviews.llvm.org/D123403?vs=42286
peixin accepted this revision.
peixin added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135
+ UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46)
+ UnorderedRuntimeSimd = BaseRunt
Meinersbur updated this revision to Diff 422862.
Meinersbur added a comment.
- address review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123403/new/
https://reviews.llvm.org/D123403
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/test/OpenM
Meinersbur marked 7 inline comments as done.
Meinersbur added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135
+ UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46)
+ UnorderedRuntimeSimd = BaseRuntimeSimd | ModifierUnordered, //
peixin added a comment.
A few comments. Mostly nits.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3767
+ /*HasMonotonicModifier=*/false, /*HasNonmonotonicModifier=*/false,
+ /*HasOrdedClause=*/false);
return;
Comme
Meinersbur created this revision.
Meinersbur added reviewers: peixin, tianshilei1992, jdoerfert, sriharikrishna,
Leporacanthicus, kiranchandramohan, clementval.
Meinersbur added a project: OpenMP.
Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr,
Chia-hungDuan, ormris, dcaballe,
