Re: [PATCH] D12344: ARM: Error out if float-ab=hard and abi=apcs-gnu on macho platforms

2016-08-01 Thread Vedant Kumar via cfe-commits
vsk closed this revision. vsk added a comment. Done in clang/r246054 https://reviews.llvm.org/D12344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12344: ARM: Error out if float-ab=hard and abi=apcs-gnu on macho platforms

2015-08-26 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. float-abi=hard has no effect on the backend code-generation if the ABI is APCS, meaning GPRs will be used to pass floating point arguments. This patch makes changes to the driver so that the error is detected in the front-end rather than silently ignoring the option in

Re: [PATCH] D12344: ARM: Error out if float-ab=hard and abi=apcs-gnu on macho platforms

2015-08-25 Thread Vedant Kumar via cfe-commits
vsk added a comment. Yep, this looks fine. Out of curiosity, what happens if we permit the MachO + !useAAPCS + FloatABI=hard case? http://reviews.llvm.org/D12344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D12344: ARM: Error out if float-ab=hard and abi=apcs-gnu on macho platforms

2015-08-25 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: vsk. ahatanak added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch corrects http://reviews.llvm.org/D12155, which didn't take into account the fact that aapcs ABI can be selected on darwin platforms. T