[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-20 Thread serge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7b98c383df: [clang-tblgen] Automatically document options values (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682 ___ cfe-commits mailing list

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-20 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 423890. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Adopt a better wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-19 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a comment. In D123682#3455793 , @aaron.ballman wrote: > In D123682#3454627 , > @serge-sans-paille wrote: > >> @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt >> any

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D123682#3454627 , @serge-sans-paille wrote: > @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt any > of those :-) I'd go with: More than two choices: ` should be 'return', 'branch', 'full',

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt any of those :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123682#3450215 , @MaskRay wrote: > Thank you for improving the tool :) > > cd clang > path/to/clang-tblgen --gen-opt-docs -I

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added subscribers: dexonsmith, aaron.ballman. MaskRay added a comment. cd clang path/to/clang-tblgen --gen-opt-docs -I ../llvm/include -I include/clang/Driver include/clang/Driver/ClangOptionDocs.td > /tmp/0 nvim -d docs/ClangCommandLineReference.rst /tmp/0 Hope a native speaker

[PATCH] D123682: [clang-tblgen] Automatically document options values

2022-04-13 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a port of