[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-23 Thread Alok Kumar Sharma via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa48300aee570: [clang][OpenMP][DebugInfo] Debug support for TLS variables present in OpenMP… (authored by alok). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-22 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Oh, it's a //global// variable that supposed to shadow the function parameter! Thanks for clarifying. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123787/new/

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-18 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok updated this revision to Diff 423362. alok added a comment. Re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123787/new/ https://reviews.llvm.org/D123787 Files: clang/include/clang/AST/Decl.h clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-18 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok added a comment. In D123787#3452970 , @aprantl wrote: >> For an example, if thread local variable is present in copyin clause >> (testcase attached with the > > patch), parameter with same name is generated as parameter to artificial > function.

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-14 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. > For an example, if thread local variable is present in copyin clause > (testcase attached with the patch), parameter with same name is generated as parameter to artificial function. When user inquires the thread Local variable, its debug info is hidden by the

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

2022-04-14 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok created this revision. alok added reviewers: jmorse, aprantl, djtodoro, jini.susan. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. Herald added a project: All. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: