[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

This revision was automatically updated to reflect the committed changes. Closed by commit rGf49d576a882d: [CUDA] Add wrapper code generation for registering CUDA images (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D123812?vs=426467=428622#toc Repository: rG LLVM

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); tra wrote: >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. In D123812#3496914 , @yaxunl wrote: > LGTM. Did you forget to accept the revision? D123810 and D123471 still need to be looked at, but these are mostly

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jdoerfert added a comment. Are there unresolved concerns we should address in this review? Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { +

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 426467. jhuber6 added a comment. Updating code generation. Previously we would seg-fault in the case that no offloading entries were created. To solve this we simply check that Begin != End before trying to register anything. Repository: rG LLVM Github

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 424536. jhuber6 added a comment. Applied changes to wrong commit, whoops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 424534. jhuber6 added a comment. Herald added a subscriber: MaskRay. Adding warning for using both `-fno-gpu-rdc` and `-foffload-new-driver`. I think this is a good warning to have for now while this is being worked in as opt-in. Once this has matured I

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423993. jhuber6 added a comment. Herald added a subscriber: sstefan1. Adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module --dry-run

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423796. jhuber6 added a comment. Addings tests for wrapper codegen and fatbinary usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. In D123812#3459164 , @yaxunl wrote: > need a CodeGenCUDA test for the registering. Also need a Driver test for the > subcommands. Testing things inside the linker wrapper is a little hairy. I may need to add a special option

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added a comment. Also, I am wondering whether we should document the new embedding scheme: section names, symbol names, entries, etc, if it has not bee done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added a comment. need a CodeGenCUDA test for the registering. Also need a Driver test for the subcommands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); tra wrote: >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); jhuber6 wrote: >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); tra wrote: >

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module ) { + LLVMContext = M.getContext(); Do you think

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. For reference, this is how I used this driver to offload a CUDA and OpenMP offload kernel that both called an external "hello world" function in `device.cu`. $ clang++ hello.cu device.cu -foffload-new-driver --offload-arch=sm_70 -c $ clang++ openmp.cpp

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds