This revision was automatically updated to reflect the committed changes.
LegalizeAdulthood marked 2 inline comments as done.
Closed by commit rG08881c2de66b: [clang-tidy] Improve macro handling in
modernize-macro-to-enum (authored by LegalizeAdulthood).
Repository:
rG LLVM Github Monorepo
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for the fix!
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235
SmallVector Files;
+ std::vector ExpressionNames;
LegalizeAdulthood marked 2 inline comments as done.
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235
SmallVector Files;
+ std::vector ExpressionNames;
FileState *CurrentFile = nullptr;
aaron.ballman added a comment.
Generally looks correct to me, but I did have some questions about the types
used in the fix.
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235
SmallVector Files;
+ std::vector ExpressionNames;
FileState
LegalizeAdulthood updated this revision to Diff 423265.
LegalizeAdulthood added a comment.
Internal methods are private
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123889/new/
https://reviews.llvm.org/D123889
Files:
clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp
LegalizeAdulthood updated this revision to Diff 423259.
LegalizeAdulthood added a comment.
Make method names symmetric
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123889/new/
https://reviews.llvm.org/D123889
Files:
clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp
LegalizeAdulthood updated this revision to Diff 423258.
LegalizeAdulthood added a comment.
Add more test cases
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123889/new/
https://reviews.llvm.org/D123889
Files:
clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp
LegalizeAdulthood added a comment.
This is an initial pass. While I believe the code handles other scenarios, I
still need to add some more test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123889/new/
https://reviews.llvm.org/D123889
LegalizeAdulthood created this revision.
LegalizeAdulthood added reviewers: aaron.ballman, klimek.
LegalizeAdulthood added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
LegalizeAdulthood requested review of this revision.
When a
