[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-07-24 Thread David Chisnall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94c3b169785c: Fix crash in ObjC codegen introduced with… (authored by theraven). Changed prior to commit:

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-04-26 Thread Frederik Seiffert via Phabricator via cfe-commits
triplef accepted this revision. triplef added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I tested these changes with our app’s code base, which was triggering the bug in a couple of places, and it all builds fine with the patch. Repository: rG LLVM Github

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-04-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D123898#3455933 , @theraven wrote: > I'd like to. The test case from the original bug report was very large but > I'm not sure how to trigger this with anything comprehensibly small. You > need something where the callee

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-04-17 Thread David Chisnall via Phabricator via cfe-commits
theraven added a comment. I'd like to. The test case from the original bug report was very large but I'm not sure how to trigger this with anything comprehensibly small. You need something where the callee is responsible for destroying the argument and I'm not sure what combination of

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-04-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. LGTM. Could you add a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123898/new/ https://reviews.llvm.org/D123898 ___ cfe-commits mailing list

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

2022-04-16 Thread David Chisnall via Phabricator via cfe-commits
theraven created this revision. theraven added reviewers: rjmccall, triplef. Herald added a project: All. theraven requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 5ab6ee75994d645725264e757d67bbb1c96fb2b6