[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3a235aa2e6: [clang-apply-replacements] Added an option to ignore insert conflict. (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432829. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432522. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this has sat for long enough and my LGTM will have to suffice. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Hi, Could anyone please review this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

MTC added a comment. In D123924#3482342 , @aaron.ballman wrote: > I don't know enough about this code base to feel comfortable signing off on > it, but the changes look reasonable to me FWIW. Thanks, Aaron! I will find another guy to review the

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

aaron.ballman added a comment. I don't know enough about this code base to feel comfortable signing off on it, but the changes look reasonable to me FWIW. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke marked an inline comment as done. Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 425166. Sockke added a comment. Rename the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files:

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

MTC added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/AtomicChange.h:119 + Replacements () { return Replaces; } + IMHO, there is no need to rename the method to get the non-const version. The following code is ok enough

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 423359. Sockke retitled this revision from "[clang-apply-replacements] Added support for adjusting conflict offset." to "[clang-apply-replacements] Added an option to ignore insert conflict.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/