[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

This revision was automatically updated to reflect the committed changes. Closed by commit rG87468e85fcdc: compile commands header to source heuristic lower-cases filenames before… (authored by ishaangandhi, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added a comment. In D124262#3472079 , @sammccall wrote: > Thanks! > I can land this for you if you don't have commit access - can you provide the > name/email to use for the commit? Thank you! Ishaan Gandhi ishaangan...@gmail.com

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can land this for you if you don't have commit access - can you provide the name/email to use for the commit? CHANGES SINCE LAST ACTION

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424914. ishaangandhi added a comment. Made test case reflect that proxies for ".H" files are ".C" files, and not ".c files". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files:

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added inline comments. Comment at: clang/unittests/Tooling/CompilationDatabaseTest.cpp:852 + add("other/random/path.cpp"); + // Proxies for ".H" files are ".C" files, and not ".cpp files" + EXPECT_EQ(getProxy("foo/bar/baz/exact.H"), "foo/bar/baz/exact.C");

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

sammccall added a comment. In D124262#3471841 , @ishaangandhi wrote: > Test case added, re-diffed with `-U`, and removed redundant constructor. > Thanks for the quick feedback, @sammccall! > > (I didn't wait for the tests to run locally, I am

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424906. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp clang/unittests/Tooling/CompilationDatabaseTest.cpp Index:

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Test case added, re-diffed with `-U`, and removed redundant constructor. Thanks for the quick feedback, @sammccall! (I didn't wait for the tests to run locally, I am hoping to use your CI systems to do that. It

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424904. ishaangandhi added a comment. - Added a test case - Removed redundant "StringRef" constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files:

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

sammccall added a comment. Change looks good, thank you! Can you add a test demonstrating it, and update the diff here? Take a look at the `InterpolateTest` cases in `clang/unittests/Tooling/CompilationDatabaseTest.cpp`. (If you can, please create diffs with context using `-U9` - this lets

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi created this revision. ishaangandhi added reviewers: nridge, sammccall. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ishaangandhi requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang.