This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b762b3ab8d2: [clang][NFC] In parts of Objective-C Sema use
Obj-C-specific types instead of… (authored by vsapsai).
Repository:
rG LLVM Github Mon
vsapsai updated this revision to Diff 425891.
vsapsai added a comment.
Simplify pointer comparison.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124285/new/
https://reviews.llvm.org/D124285
Files:
clang/include/clang/Parse/Parser.h
clang/incl
vsapsai added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:17067
+void Sema::ActOnObjCTemporaryExitContainerContext(ObjCContainerDecl *ObjCCtx) {
+ auto DC = cast(ObjCCtx);
assert(DC == CurContext && "Mismatch of container contexts");
jansvoboda11
jansvoboda11 added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:3300
- Decl *ActOnObjCContainerStartDefinition(Decl *IDecl);
+ void ActOnObjCContainerStartDefinition(ObjCContainerDecl *IDecl);
vsapsai wrote:
> jansvoboda11 wrote:
> > Why the
vsapsai updated this revision to Diff 425334.
vsapsai marked an inline comment as done.
vsapsai added a comment.
Drop unnecessary `cast<>`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124285/new/
https://reviews.llvm.org/D124285
Files:
clang/i
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:3300
- Decl *ActOnObjCContainerStartDefinition(Decl *IDecl);
+ void ActOnObjCContainerStartDefinition(ObjCContainerDecl *IDecl);
jansvoboda1
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM with two minor questions.
Comment at: clang/include/clang/Sema/Sema.h:3300
- Decl *ActOnObjCContainerStartDefinition(Decl *IDecl);
+ void ActOnObjCContai
vsapsai created this revision.
vsapsai added reviewers: jansvoboda11, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
vsapsai requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D124285
File