[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:56 ClangTidyCheck::OptionsView::get(StringRef LocalName) const { - const auto = CheckOptions.find(NamePrefix + LocalName.str()); + const auto = CheckOptions.find((NamePrefix

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

uabelho added a comment. In D124341#3504427 , @njames93 wrote: > In D124341#3502659 , @uabelho wrote: > >> Hi, >> >> I noticed that this patch isn't NFC. > > Whoops, good catch. I left in some debugging code,

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 added a comment. In D124341#3502659 , @uabelho wrote: > Hi, > > I noticed that this patch isn't NFC. Whoops, good catch. I left in some debugging code, fixed in rGa308a55720249749

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

uabelho added a comment. Hi, I noticed that this patch isn't NFC. If I run clang-tidy -checks='*' empty.c -- on an empty file empty.c I get the following printouts with this patch: 'addr=address' 'arr=array' 'attr=attribute' 'buf=buffer' 'cl=client' 'cnt=count' 'col=column'

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

This revision was automatically updated to reflect the committed changes. njames93 marked 4 inline comments as done. Closed by commit rG12cb540529e4: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would… (authored by njames93). Repository: rG LLVM Github Monorepo

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D124341#3476533 , @njames93 wrote: > In D124341#3475083 , @aaron.ballman > wrote: > >> I

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:51 ClangTidyContext *Context) -: NamePrefix(CheckName.str() + "."), CheckOptions(CheckOptions), +: NamePrefix((CheckName +

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:51 ClangTidyContext *Context) -: NamePrefix(CheckName.str() + "."), CheckOptions(CheckOptions), +: NamePrefix((CheckName + ".").str()), CheckOptions(CheckOptions),

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 added a comment. In D124341#3475083 , @aaron.ballman wrote: > I went through the changes and they look correct to me... yet I'm still > mildly terrified. :-D Have you tried running clang-tidy through its paces > with ASan/MSan enabled to see

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

aaron.ballman added a comment. I went through the changes and they look correct to me... yet I'm still mildly terrified. :-D Have you tried running clang-tidy through its paces with ASan/MSan enabled to see if the change introduces any use-after-free issues in practice? Repository: rG LLVM

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 created this revision. Herald added subscribers: carlosgalvezp, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github