Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

This revision was automatically updated to reflect the committed changes. Closed by commit rL246618: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610) (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12444?vs=33623=33777#toc Repository: rL LLVM

Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

majnemer added a comment. I think it'd be nice if we keep the assert but make `setTagNameForLinkagePurposes` early-return if `TagFromDeclSpec->isInvalidDecl()` returns true. How does that sound to you? http://reviews.llvm.org/D12444 ___

[PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

vsk created this revision. vsk added a subscriber: cfe-commits. We currently assert-fail on the following input: enum Color { R, G, B }; typedef struct Color C; This patch just changes the assert to a conditional. https://llvm.org/bugs/show_bug.cgi?id=24610 http://reviews.llvm.org/D12444