[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. In D124606#3484740 , @Meinersbur wrote: > In D124606#3479793 , @ilya-biryukov > wrote: > >> LGTM > > This and the commit (@MForster ) was too hasty. There should have been time >

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Meinersbur added a comment. In D124606#3479793 , @ilya-biryukov wrote: > LGTM This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 and D97625

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added a comment. In D124606#3480281 , @labath wrote: > In D124606#3480164 , @aaronpuchert > wrote: > >> An editor could inadvertently change the line endings, and someone might not >> notice before

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

labath added a comment. In D124606#3480164 , @aaronpuchert wrote: > Fair enough, but don't we want to enforce LF or CRLF, respectively? Sure, but is the version control system the right tool to do that? I think it'd be better to have the test itself

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added a comment. Also I still don't understand what specifically this is fixing. What exactly was wrong about the previous configuration? The commit message talks about "various workflows" but which workflows are that? Does that mean no one can use `.gitattributes` with something

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added a comment. Fair enough, but don't we want to enforce LF or CRLF, respectively? An editor could inadvertently change the line endings, and someone might not notice before commiting. Explicitly specifying the right line endings gives us the proper line endings even if some

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. Well, I tested this on Windows. :-) forster@Desktop MINGW64 ~/src/llvm-project/clang-tools-extra/test (main) $ git reset --hard 4aba5fa774821279c2e2e26dd6ed6e1c6a151044 && grep 'crlf.cpp ' .gitattributes && file clang-apply-replacements/Inputs/crlf/crlf.cpp HEAD

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. @labath, ah, sorry, you beat me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___ cfe-commits mailing list

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. In D124606#3480012 , @aaronpuchert wrote: > I think this change broke again what D97625 > was trying to fix. These are text files and we want them to keep the > specified line endings

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

labath added inline comments. Comment at: clang-tools-extra/test/.gitattributes:7-15 +clang-apply-replacements/ClangRenameClassReplacements.cpp -text +clang-apply-replacements/Inputs/basic/basic.h -text +clang-apply-replacements/Inputs/format/no.cpp -text

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

aaronpuchert added subscribers: smeenai, aaronpuchert. aaronpuchert added a comment. I think this change broke again what D97625 was trying to fix. These are text files and we want them to keep the specified line endings regardless of the local git

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479805 , @MForster wrote: > In D124606#3479798 , @ilya-biryukov > wrote: > >> NIT: change the commit message to say `-text` instead of `binary` > > Ah, sorry, saw this too