[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster added a comment. In D124606#3479798 , @ilya-biryukov wrote: > NIT: change the commit message to say `-text` instead of `binary` Ah, sorry, saw this too late... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aba5fa77482: Use `-text` git attribute instead of `text eol=...` (authored by MForster). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

ilya-biryukov added a comment. NIT: change the commit message to say `-text` instead of `binary` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

ilya-biryukov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425745. MForster added a comment. Use `-text` instead of `binary`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files: clang-tools-extra/test/.gitattributes

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

labath added a comment. I believe (based on some similar issues I was solving in lldb) that `-text` instead of `binary` is sufficient to prevent git from fidlling with the contents, while maintaining the ability to diff the files. Other than that, I am in favour of this approach, but I'd

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster updated this revision to Diff 425742. MForster added a comment. Force-add crlf.cpp(.expected) with CRLF line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124606/new/ https://reviews.llvm.org/D124606 Files:

[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

MForster created this revision. MForster added a reviewer: labath. Herald added a subscriber: jdoerfert. Herald added a project: All. MForster requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These automatic conversions lead to