[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. > But that's not a problem of this patch, and we will address that later if > needed. Thanks for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

vitalybuka added a comment. In D124699#3549191 , @kstoimenov wrote: > This change is breaking memory sanitizer in some cases. We observed that > when the argument is not actually removed the pass is dropping the noundef > attribute. See the diff

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

kstoimenov added a comment. This change is breaking memory sanitizer in some cases. We observed that when the argument is not actually removed the pass is dropping the noundef attribute. See the diff snippet below. Is that an intended behavior? We would like to revert this as it is breaking

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9766fed9c10e: [DeadArgElim] Re-apply: Set unused arguments for internal functions (authored by qcolombet). Repository: rG LLVM Github Monorepo

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

fhahn added a comment. In D124699#3507250 , @qcolombet wrote: > Thanks @thakis ! > > @fhahn are you okay with the clang tests update as well? Yes looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. Thanks @thakis ! @fhahn are you okay with the clang tests update as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

thakis added a comment. Updating the tests makes sense to me, fwiw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___ cfe-commits mailing list

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a subscriber: vitalybuka. qcolombet added a comment. Hi @thakis , @dyung , @vitalybuka, Thanks for the heads-up and the revert. Fixed clang tests included in the diff. Cheers, -Quentin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet updated this revision to Diff 426555. qcolombet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - includes fixes to clang tests that were missed in the original commit. If someone knows who we can add from the clang side to double check the tests