[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push craig.topper wrote: > The argument should

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:48 +#pragma clang diagnostic ignored "-Wuninitialized" unsigned int t; return __builtin_ia32_rdsspd(t); So if CET isn't enabled this intrinsic returns a random value instead of 0

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push The argument should also be `(void)`. Comment at:

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d18a86d14a9: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei added a comment. In D124916#3490868 , @RKSimon wrote: > LGTM - I'm intending to add -Wsystem-headers to the clang x86 builtins tests > once everything is clean. Thanks @RKSimon! That sounds great! I was thinking the headers will do diagnosis

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - I'm intending to add -Wsystem-headers to the clang x86 builtins tests once everything is clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei updated this revision to Diff 426971. pengfei added a comment. Seperated unrelated change and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124916/new/ https://reviews.llvm.org/D124916 Files: clang/lib/Headers/cetintrin.h

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins-constrained.c:5 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-linux-gnu -target-feature +sse -S -o - -Wall -Werror | FileCheck %s --check-prefix=CHECK-ASM --check-prefix=COMMON +//

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins-constrained.c:5 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-linux-gnu -target-feature +sse -S -o - -Wall -Werror | FileCheck %s --check-prefix=CHECK-ASM --check-prefix=COMMON +//

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei created this revision. pengfei added reviewers: FreddyYe, RKSimon, LuoYuanke, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix