[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd38caf3b5b7: [clang][dataflow] Track `optional` contents in `optional` model. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 435537. ymandel added a comment. add missing blank line to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files:

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 435528. ymandel added a comment. rebase and merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files:

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel added a comment. sgatev@ -- gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 429211. ymandel added a comment. remove stray FIXME from previous diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 429210. ymandel marked 6 inline comments as done. ymandel added a comment. address reviewer comments and fix bug in how the nested value as _re_created -- now uses the loc's type rather than the expression's type (which doesn't always match exactly).

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel marked 8 inline comments as done. ymandel added a comment. I'm having trouble with arcanist -- `arc diff` is crashing, but wanted to respond in the meantime to your questions. I hope I'll be able to actually upload the new diff soon... Comment at:

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:170 /// Returns the symbolic value that represents the "has_value" property of the -/// optional value `Val`. Returns null if `Val` is null. -BoolValue

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

xazax.hun added a comment. Thanks for the clarifications! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 ___ cfe-commits mailing list

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel added a comment. In D124932#3492495 , @xazax.hun wrote: > Overall looks good to me. I am curious what will the strategy be to properly > support construction. Do you plan to introduce a customization point to > `Env.createValue` to give

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 427296. ymandel added a comment. Fixed the FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files:

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

xazax.hun added a comment. Overall looks good to me. I am curious what will the strategy be to properly support construction. Do you plan to introduce a customization point to `Env.createValue` to give checks/models a way to set properties up? Or do you have something else in mind?

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 427029. ymandel added a comment. remove stray newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: