[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

This revision was automatically updated to reflect the committed changes. Closed by commit rG76910d4a56c8: [pseudo] Share the underly payload when stripping comments for a token stream (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. In D125311#3524190 , @sammccall wrote: > In D125311#3523388 , @hokein wrote: > >> In D125311#3503452 , @sammccall >> wrote: >> >>> This looks

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein updated this revision to Diff 430646. hokein added a comment. add addPayload method, and share payload in cook as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311 Files:

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

sammccall added a comment. In D125311#3523388 , @hokein wrote: > In D125311#3503452 , @sammccall > wrote: > >> This looks good, but if that's the idiom we should add it to cook() also. > > cook is more tricky,

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. In D125311#3503452 , @sammccall wrote: > This looks good, but if that's the idiom we should add it to cook() also. cook is more tricky, it takes a TokenStream, and returns a new one with an allocator payload: - the input

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

sammccall added a comment. This looks good, but if that's the idiom we should add it to cook() also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311 ___

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. Example: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/pseudo/tool/ClangPseudo.cpp#L88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. `stripComments(cook(...))` is a common pattern being written. Without this