krasin updated this revision to Diff 33849.
krasin added a comment.
Addressed a nit.
http://reviews.llvm.org/D12544
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
lib/Frontend/CompilerInvocation.cpp
pcc added a comment.
It's probably time to add something like the driver test I was talking about in
http://reviews.llvm.org/D12021. Without that, you will have no test coverage
for the functional change here.
http://reviews.llvm.org/D12544
___
krasin updated this revision to Diff 33764.
krasin added a comment.
Add a test for default blacklist.
http://reviews.llvm.org/D12544
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
lib/Frontend/CompilerInvocation.cpp
krasin added a comment.
In http://reviews.llvm.org/D12544#237819, @pcc wrote:
> It's probably time to add something like the driver test I was talking about
> in http://reviews.llvm.org/D12021. Without that, you will have no test
> coverage for the functional change here.
Done, please, take
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM with nit.
Comment at: test/Driver/fsanitize-blacklist.c:25
@@ -18,1 +24,3 @@
+// CHECK-DEFAULT-BLACKLIST: -fsanitize-blacklist={{.*}}asan_blacklist.txt
+//
