[PATCH] D125669: Adding support for target in_reduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8322fe200d60: Adding support for target in_reduction (authored by RitanyaB, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D125669: Adding support for target in_reduction

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125669: Adding support for target in_reduction

ssquare08 added a comment. In D125669#3604452 , @ABataev wrote: > In D125669#3604302 , @RitanyaB > wrote: > >> In D125669#3599134 , @ABataev >> wrote: >> >>> What about

[PATCH] D125669: Adding support for target in_reduction

ABataev added a comment. In D125669#3604302 , @RitanyaB wrote: > In D125669#3599134 , @ABataev wrote: > >> What about the description? Shall we still emit ` if(0)`? > > Can you please elaborate for more clarity?

[PATCH] D125669: Adding support for target in_reduction

RitanyaB marked an inline comment as done. RitanyaB added a comment. In D125669#3599134 , @ABataev wrote: > What about the description? Shall we still emit ` if(0)`? Can you please elaborate for more clarity? Comment at: clang/lib/Cod

[PATCH] D125669: Adding support for target in_reduction

ABataev added a comment. What about the description? Shall we still emit ` if(0)`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D125669: Adding support for target in_reduction

RitanyaB updated this revision to Diff 438554. RitanyaB added a comment. The if condition in the method EmitOMPTargetTaskBasedDirective in CGStmtOpenMP.cpp file was removed since it was unnecessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125

[PATCH] D125669: Adding support for target in_reduction

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5035-5039 +llvm::APInt TrueOrFalse(32, +S.hasClausesOfKind() ? 0 : 1); +IntegerLiteral IfCond(getContext(), TrueOrFalse, + getContext().getI

[PATCH] D125669: Adding support for target in_reduction

RitanyaB added a comment. Could someone please review the changes? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list cfe-com

[PATCH] D125669: Adding support for target in_reduction

RitanyaB created this revision. RitanyaB added reviewers: soumitra, koops, ssquare08, cchen, dreachem. Herald added a project: All. RitanyaB requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: c