This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2fb6ece2ca83: Optimise findRefs for XRefs and docHighlights
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
usaxena95 updated this revision to Diff 429807.
usaxena95 marked 4 inline comments as done.
usaxena95 added a comment.
Addressed comments and added performance measurements.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125675/new/
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for noticing this, LGTM!
Comment at: clang-tools-extra/clangd/XRefs.cpp:961
const ParsedAST
- const llvm::DenseSet
+ llvm::DenseMap TargetDeclAndID;
};
usaxena95 updated this revision to Diff 429697.
usaxena95 added a comment.
Format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125675/new/
https://reviews.llvm.org/D125675
Files:
clang-tools-extra/clangd/XRefs.cpp
Index:
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:951
if (const auto *Tok = TB.spelledTokenAt(L))
-References.push_back({*Tok, Roles, ID});
+References.push_back({*Tok, Roles, getSymbolID(D)});
}
kadircet
usaxena95 updated this revision to Diff 429696.
usaxena95 marked 4 inline comments as done.
usaxena95 added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125675/new/
https://reviews.llvm.org/D125675
Files:
kadircet added a reviewer: kadircet.
kadircet added a comment.
66% win sounds great, it would be nice to have some detailed numbers (but this
is clearly a huge win, so no need to reperform the experiments if numbers are
gone)
Comment at:
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Reduces time spent in findRef by 66%.
Repository:
rG LLVM
