[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a05942dd0c5: [pseudo] Remove the explicit Accept actions. (authored by hokein). Changed prior to commit:

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params, [&](const GSS::Node *NewHead) {

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params,

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params, [&](const GSS::Node *NewHead) {

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein updated this revision to Diff 435309. hokein marked an inline comment as done. hokein added a comment. switch to the previous simple version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125677/new/ https://reviews.llvm.org/D125677 Files:

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() << llvm::formatv("Accept: {0} accepted result:\n", -

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() << llvm::formatv("Accept: {0} accepted result:\n", - PendingAccept.size()); -

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein updated this revision to Diff 435103. hokein added a comment. pull out the logic of detecting acceptable state out of glrReduce callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125677/new/ https://reviews.llvm.org/D125677 Files:

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is a great simplification, thanks! Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() <<

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. As pointed out in the previous review section, having a dedicated accept