[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2023-06-06 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. I believe this was superseded by D151190 , should we close this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125863/new/ https://reviews.llvm.org/D125863

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-06-06 Thread Qingyuan Zheng via Phabricator via cfe-commits
daiyousei-qz added a comment. I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-05-22 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Potentially related issue: https://github.com/clangd/clangd/issues/773 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125863/new/ https://reviews.llvm.org/D125863 ___ cfe-commits

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-05-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D125863#3522384 , @kadircet wrote: > In D125863#3522025 , @hokein wrote: > >> sorry, I might be lack of the context, where is the user complaint? I'm not >> sure which cases are

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-05-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added a comment. In D125863#3522025 , @hokein wrote: > sorry, I might be lack of the context, where is the user complaint? I'm not > sure which cases are improved with this patch. so the complaint was

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-05-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. sorry, I might be lack of the context, where is the user complaint? I'm not sure which cases are improved with this patch. Ideally we would not mark PP directives as inactive regions, but we never do that (FIXME

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

2022-05-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: