[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95a92995d45f: Adds the NSDateFormatter checker to clang-tidy

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ accepted this revision. NoQ added a comment. Great, thanks! Unless there are other objections from other reviewers, I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud updated this revision to Diff 449144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 Files: clang-tools-extra/clang-tidy/objc/CMakeLists.txt clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ added a comment. Uh-oh sorry! I have a couple more questions and then we can probably land. Comment at: clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp:24 + Finder->addMatcher( + objcMessageExpr(hasSelector("setDateFormat:"), +

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud updated this revision to Diff 444527. t-rasmud added a reviewer: ziqingluo-90. t-rasmud added a comment. Addresses review comments from the previously uploaded diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 Files:

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

njames93 added a comment. In D126097#3528787 , @NoQ wrote: > Looks awesome! > >> add_new_check.py > > I'm surprised it wasn't executable already, do we want to keep it? It keeps getting reset, likely due to Windows users committing changes. It should

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NsdateformatterCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +# include + `cctype`? See `modernize-deprecated-headers`. Comment at:

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ added a comment. Looks awesome! > add_new_check.py I'm surprised it wasn't executable already, do we want to keep it? Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:13 NSInvocationArgumentLifetimeCheck.cpp + NsdateformatterCheck.cpp