[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ff4f2dfea63: [clang-tidy] Fix #55134 (regression introduced by 5da7c04) (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431805. salman-javed-nz added a comment. Added release note. (Also taking the opportunity to run the patch through the pre-merge build bot one last time.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though this should have a release note for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126138/new/ https://reviews.llvm.org/D126138

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. I'm not a clang-tidy maintainer so I don't know if I have the authority to green-light this patch, but I'm fairly confident the fix is correct (it's restoring the previous usage of the

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

paulaltin added a comment. In D126138#3530172 , @salman-javed-nz wrote: > This fix is check-agnostic, so I don't think we need to add even more tests > than the two proposed here. Yes, you're right; the issue itself is check-agnostic too, I just

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. In D126138#3529820 , @paulaltin wrote: > Thanks for preparing this revision @salman-javed-nz! > > Do you think it could be worth adding a few more test cases to cover this? It > turned out that this issue wasn't actually

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431223. salman-javed-nz added a comment. Add another test, to test the specific code sample in the GitHub issue (check=cppcoreguidelines-pro-type-member-init). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. The pre-merge checks are failing on the clang-format check. Not sure why it's complaining about the formatting of the `lit` test files - those files have never complied with the project style and have not been checked for style for as long as I remember. Has

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431213. salman-javed-nz edited the summary of this revision. salman-javed-nz added a comment. Renamed test case to better explain what it is that it's testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

nridge added a comment. In D126138#3529820 , @paulaltin wrote: > It turned out that this issue wasn't actually specific to multi-line macros > (see this comment > ), Indeed,

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

paulaltin added a comment. Thanks for preparing this revision @salman-javed-nz! Do you think it could be worth adding a few more test cases to cover this? It turned out that this issue wasn't actually specific to multi-line macros (see this comment

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. F23151067: Capture.png This screenshot shows the code snippet from the GitHub issue, and Clang-Tidy's behaviour before and after this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz created this revision. salman-javed-nz added reviewers: nridge, paulaltin. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. salman-javed-nz requested review of this revision. Herald added a