This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG33b598a808b9: [clang][dataflow] Relax assert on existence of
`this` pointee storage (authored by li.zhe.hua).
Repository:
rG LLVM Github Monorepo
li.zhe.hua updated this revision to Diff 432119.
li.zhe.hua added a comment.
Accidentally a word...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126405/new/
https://reviews.llvm.org/D126405
Files:
clang/lib/Analysis/FlowSensitive/Transfer.cpp
li.zhe.hua updated this revision to Diff 432117.
li.zhe.hua marked 2 inline comments as done.
li.zhe.hua added a comment.
Address reviewer comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126405/new/
https://reviews.llvm.org/D126405
Files:
sgatev accepted this revision.
sgatev added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:282
auto *ThisPointeeLoc = Env.getThisPointeeStorageLocation();
-assert(ThisPointeeLoc != nullptr);
+if (ThisPointeeLoc == nullptr)
+ return;
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Please wait for at least one more "accept". thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126405/new/
li.zhe.hua created this revision.
li.zhe.hua added a reviewer: ymandel.
Herald added subscribers: tschuett, steakhal.
Herald added a project: All.
li.zhe.hua requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Support for unions is incomplete
