[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong added a comment. I've made some measurements with the diff down below. So, it seems like the chance of being a recursive call is very unlikely (roughly 1/1). Thus I am going to update this condition with `LLVM_UNLIKELY`. Besides, the depth of the call stack seems to be less than 4

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:21 #include "llvm/ADT/Optional.h" +#include "llvm/ADT/SmallSet.h" #include

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:140-146 /// A flag to indicate that clients should be notified of assumptions. /// By default this is the case, but sometimes this needs to be restricted

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong updated this revision to Diff 433353. martong added a comment. - Remove FIXME comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files:

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal added a comment. In D126560#3549570 , @martong wrote: > In D126560#3549408 , @steakhal > wrote: > >> This isn't an NFC change. It's more than a refactor/cosmetic change. > > Still, there is no visible

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong updated this revision to Diff 433324. martong edited the summary of this revision. martong added a comment. - Use SmallVector in AssumeStack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files:

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong marked 2 inline comments as done. martong added a comment. In D126560#3549408 , @steakhal wrote: > This isn't an NFC change. It's more than a refactor/cosmetic change. Still, there is no visible change in the behavior, at least that is intended.

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:156 + private: +llvm::SmallSet Aux; + }; steakhal wrote: > Have you considered [[ >

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal added a comment. This isn't an NFC change. It's more than a refactor/cosmetic change. Please run some benchmarks to validate the assumed performance characteristics. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:156 + private:

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code

martong updated this revision to Diff 433097. martong added a comment. - Add AssumeStack to track recursive assume calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files:

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a