[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG05130a6ba7d9: new clang-tidy checker for assignments within condition clause of if statement (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442358. dodohand added a comment. somehow, clang-format needed to be re-run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442340. dodohand added a comment. Updated to merge successfully into latest version of main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added a comment. Thanks! I'll commit this for you once you upload a refreshed patch (that applies to the main branch cleanly). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @gribozavr2, I don't have commit access... I'll address the merge issue ASAP though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand marked 4 inline comments as done. dodohand added a comment. Addressed comments from gribozavr2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 442338. dodohand added a comment. Addressing comments from @gribozavr2 identifying comments needing update/removal/improvement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 Files:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-assignment-in-if-condition.cpp:84 + +// Add something that doesn't trigger the check here. +void awesome_f2(int arg) { CHANGES SINCE LAST ACTION

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with a few minor edits. Do you have commit access? Comment at: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp:19-21 +void

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. Hi @alexfh , @aaron.ballman, Could one of you have a look at this? I'd like to get it moving toward resolution and don't know who else ought to do a review... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added a comment. @gribozavr2 , have I successfully addressed the points you brought up? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-commits mailing list

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 434610. dodohand added a comment. renamed from misc-assignment-in-if-clause to bugprone-assignment-in-if-condition per review input Adjusted documentation per review input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AssignmentInIfClauseCheck.cpp:39 + diag(MatchedDecl->getBeginLoc(), + "Assignment detected within if statement. Fix to equality check if this " + "was accidental. Consider moving out of

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AssignmentInIfClauseCheck.cpp:39 + diag(MatchedDecl->getBeginLoc(), + "Assignment detected within if statement. Fix to equality check if this " + "was accidental. Consider moving out of

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-assignment-in-if-clause.rst:9 +Finds these assignments even within multiple sets of parentheses which is often appropriate to structure multi-part condition statements. +Finds these

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-assignment-in-if-clause.rst:9 +Finds these assignments even within multiple sets of parentheses which is often appropriate to structure multi-part condition statements. +Finds these

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand created this revision. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. dodohand requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. new clang-tidy checker for assignments with the condition