[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-23 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:179 +bool +HandleTopLevelStmts(const llvm::SmallVectorImpl ) override { + if (Diags.hasErrorOccurred()) Hi @rjmccall, this patch tries to add support for statements

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-23 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 447098. v.g.vassilev added a comment. Keep the patch minimal, exclude opencl, etc for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-23 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + rsmith wrote: > In Objective-C, both declarations and expressions can start with `@`. In > general we'd need to

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-22 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 446817. v.g.vassilev added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h clang/include/clang/Parse/Parser.h

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-22 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 446815. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-07-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + In Objective-C, both declarations and expressions can start with `@`. In general we'd need to look at the next token

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

2022-06-08 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, rjmccall, lhames, sgraenitz. Herald added a subscriber: StephenFan. Herald added a project: All. v.g.vassilev requested review of this revision. This patch teaches clang to parse statements on the global scope to allow: